-
Notifications
You must be signed in to change notification settings - Fork 73
DOC Create unified release policy #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Create unified release policy #788
Conversation
0912551 to
51f2c3c
Compare
51f2c3c to
0b1338d
Compare
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming CI passes.
On to @SimulatedPanda to give approval.
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one tiny thing when viewing the rendered copy
7ef6d3f to
2d2bf41
Compare
|
I just changed " - Extended: Approximately one year, extending until the subsequent major release (e.g. CMS 5.4 will remain in partial support until CMS 7.0 is released)" to include "following subsequent" as it's a "double subsequent" jump |
0304ec6 to
2cad84f
Compare
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Just waiting for Jenn's review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change that I don't feel strongly about, but reading through again this stood out as potentially confusing.
These come from me, not Jenn
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are Jenn's review changes from slack.
2cad84f to
f4e4324
Compare
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just #788 (comment) left to do
f4e4324 to
8d04b72
Compare
GuySartorelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs approval from Jenn
|
I approve these changes and this combined policy can now be made live. |
Issue https://github.com/silverstripeltd/product-issues/issues/908
Using in favour of #753 as this targets 5.4, then other one targeted 6.
--
Copied from #753 (comment):
Things for Jenn to be aware of when reviewing and approving: