Skip to content

Conversation

@emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 31, 2025

Issue https://github.com/silverstripeltd/product-issues/issues/908

Using in favour of #753 as this targets 5.4, then other one targeted 6.

--

Copied from #753 (comment):

Things for Jenn to be aware of when reviewing and approving:

  1. This is intended to blend the major release policy and minor release policy together.
  2. It's not intended to actually change anything about our commitments, or about how we communicate those commitments, except that:
    1. The minor release policy says "Once a release candidate is tagged, only critical impact bug fixes can be added to the release" - this has been changed here to remove the word "critical" to better match reality.
    2. Wording has been updated to better clarify exactly what our commitments are. The interpretation of those commitments should not have changed, though.

@emteknetnz emteknetnz marked this pull request as ready for review July 31, 2025 03:45
@emteknetnz emteknetnz force-pushed the pulls/5.4/release-policy branch from 0912551 to 51f2c3c Compare July 31, 2025 03:45
@emteknetnz emteknetnz force-pushed the pulls/5.4/release-policy branch from 51f2c3c to 0b1338d Compare July 31, 2025 04:29
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes.
On to @SimulatedPanda to give approval.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one tiny thing when viewing the rendered copy

@emteknetnz emteknetnz force-pushed the pulls/5.4/release-policy branch 2 times, most recently from 7ef6d3f to 2d2bf41 Compare July 31, 2025 22:32
@emteknetnz
Copy link
Member Author

I just changed " - Extended: Approximately one year, extending until the subsequent major release (e.g. CMS 5.4 will remain in partial support until CMS 7.0 is released)" to include "following subsequent" as it's a "double subsequent" jump

@emteknetnz emteknetnz force-pushed the pulls/5.4/release-policy branch 2 times, most recently from 0304ec6 to 2cad84f Compare July 31, 2025 22:56
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just waiting for Jenn's review.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change that I don't feel strongly about, but reading through again this stood out as potentially confusing.
These come from me, not Jenn

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are Jenn's review changes from slack.

@emteknetnz emteknetnz force-pushed the pulls/5.4/release-policy branch from 2cad84f to f4e4324 Compare August 1, 2025 05:45
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just #788 (comment) left to do

@emteknetnz emteknetnz force-pushed the pulls/5.4/release-policy branch from f4e4324 to 8d04b72 Compare August 3, 2025 22:35
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs approval from Jenn

@SimulatedPanda
Copy link

I approve these changes and this combined policy can now be made live.

@GuySartorelli GuySartorelli merged commit b66f8e8 into silverstripe:5.4 Aug 3, 2025
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.4/release-policy branch August 3, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants