Skip to content

Conversation

@GuySartorelli
Copy link
Member

```

### `subtract`
### `filterByList` and `excludeByList`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### `filterByList` and `excludeByList`
### `filterByList()` and `excludeByList()`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly kept those off to match the other headings in this page. Happy to add them to all method-name headings in this page though if you prefer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense to add to all the headings

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


### Other new features and enhancements {#other-new}

- New [`DataList::filterByList()`](api:SilverStripe\ORM\DataList::filterByList()) and [`DataList::excludeByList()`](api:SilverStripe\ORM\DataList::excludeByList()) methods allow filtering by or excluding based on the results of another list. See [`filterByList` and `excludeByList`](/developer_guides/model/data_model_and_orm/#filterbylist-and-excludebylist) for details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- New [`DataList::filterByList()`](api:SilverStripe\ORM\DataList::filterByList()) and [`DataList::excludeByList()`](api:SilverStripe\ORM\DataList::excludeByList()) methods allow filtering by or excluding based on the results of another list. See [`filterByList` and `excludeByList`](/developer_guides/model/data_model_and_orm/#filterbylist-and-excludebylist) for details.
- New [`DataList::filterByList()`](api:SilverStripe\ORM\DataList::filterByList()) and [`DataList::excludeByList()`](api:SilverStripe\ORM\DataList::excludeByList()) methods allow filtering by or excluding based on the results of another list. See [`filterByList()` and `excludeByList()`](/developer_guides/model/data_model_and_orm/#filterbylist-and-excludebylist) for details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion will be in #789 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

```

### `subtract`
### `filterByList` and `excludeByList`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense to add to all the headings

@GuySartorelli GuySartorelli force-pushed the pulls/6/filterexcludebylist branch from 3bbd4bb to d2c6766 Compare August 5, 2025 23:37
@emteknetnz emteknetnz merged commit 347981b into silverstripe:6 Aug 6, 2025
3 checks passed
@emteknetnz emteknetnz deleted the pulls/6/filterexcludebylist branch August 6, 2025 00:20
lozcalver pushed a commit to lozcalver/developer-docs that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants