-
Notifications
You must be signed in to change notification settings - Fork 73
DOC Document excluding and filtering by another list's results #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Document excluding and filtering by another list's results #789
Conversation
| ``` | ||
|
|
||
| ### `subtract` | ||
| ### `filterByList` and `excludeByList` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### `filterByList` and `excludeByList` | |
| ### `filterByList()` and `excludeByList()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explicitly kept those off to match the other headings in this page. Happy to add them to all method-name headings in this page though if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah makes sense to add to all the headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
en/08_Changelogs/6.1.0.md
Outdated
|
|
||
| ### Other new features and enhancements {#other-new} | ||
|
|
||
| - New [`DataList::filterByList()`](api:SilverStripe\ORM\DataList::filterByList()) and [`DataList::excludeByList()`](api:SilverStripe\ORM\DataList::excludeByList()) methods allow filtering by or excluding based on the results of another list. See [`filterByList` and `excludeByList`](/developer_guides/model/data_model_and_orm/#filterbylist-and-excludebylist) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - New [`DataList::filterByList()`](api:SilverStripe\ORM\DataList::filterByList()) and [`DataList::excludeByList()`](api:SilverStripe\ORM\DataList::excludeByList()) methods allow filtering by or excluding based on the results of another list. See [`filterByList` and `excludeByList`](/developer_guides/model/data_model_and_orm/#filterbylist-and-excludebylist) for details. | |
| - New [`DataList::filterByList()`](api:SilverStripe\ORM\DataList::filterByList()) and [`DataList::excludeByList()`](api:SilverStripe\ORM\DataList::excludeByList()) methods allow filtering by or excluding based on the results of another list. See [`filterByList()` and `excludeByList()`](/developer_guides/model/data_model_and_orm/#filterbylist-and-excludebylist) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion will be in #789 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| ``` | ||
|
|
||
| ### `subtract` | ||
| ### `filterByList` and `excludeByList` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah makes sense to add to all the headings
3bbd4bb to
d2c6766
Compare
Issue