Rename Moped::BSON::ObjectID to BSON::ObjectId and Add restore callbacks.#8
Closed
zhouguangming wants to merge 2 commits intosimi:masterfrom
zhouguangming:master
Closed
Rename Moped::BSON::ObjectID to BSON::ObjectId and Add restore callbacks.#8zhouguangming wants to merge 2 commits intosimi:masterfrom zhouguangming:master
zhouguangming wants to merge 2 commits intosimi:masterfrom
zhouguangming:master
Conversation
Owner
|
@zhouguangming I just added same commits :) LOL |
Owner
Owner
|
I merged my PR since I committed it sooner. Our codes are basically same. Thanks for idea. What a crazy coincidence we made same commits within 2 minutes. ⌚ Time to improve README. |
Author
|
Yes, I was shocked. 💖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moped beta 2 uses the 10gen bson gem (2.0.0.rc2), so just use BSON:ObjectId now.
https://github.com/mongoid/mongoid/issues/3294
Can you review this PR? @simi