Bump CMake minimum version to oldest non-deprecated#2
Open
adamnovak wants to merge 1 commit intosimongog:masterfrom
Open
Bump CMake minimum version to oldest non-deprecated#2adamnovak wants to merge 1 commit intosimongog:masterfrom
adamnovak wants to merge 1 commit intosimongog:masterfrom
Conversation
CMake 4 has started failing builds on CMakeLists.txt files that claim to be compatible with CMake 3.5 or earlier, on the theory that that's unlikely to actually be under CI testing in the project being built. There's a workaround of defining a variable on the command line, but that doesn't work if the offending project is behind two or more levels of dependencies. This updates the CMakeLists.txt to build on CMake 4, and notes that it contemplates CMake versions up to 4.0, while dropping support for building on versions of CMake that CMake 4 deprecates.
Author
|
|
adamnovak
added a commit
to vgteam/vg
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4 has started failing builds on CMakeLists.txt files that claim to be compatible with CMake 3.5 or earlier, on the theory that that's unlikely to actually be under CI testing in the project being built. There's a workaround of defining a variable on the command line, but that doesn't work if the offending project is behind two or more levels of dependencies.
This updates the CMakeLists.txt to build on CMake 4, and notes that it contemplates CMake versions up to 4.0, while dropping support for building on versions of CMake that CMake 4 deprecates.