Merged
Conversation
Turbo87
reviewed
Feb 21, 2018
package.json
Outdated
| "ember-cli-htmlbars-inline-precompile": "^1.0.0", | ||
| "ember-cli-inject-live-reload": "^1.4.1", | ||
| "ember-cli-mocha": "^0.14.4", | ||
| "ember-cli-mocha": "emberjs/ember-mocha#master", |
There was a problem hiding this comment.
interesting that this works... ember-cli-mocha vs ember-mocha 😉
Owner
Author
There was a problem hiding this comment.
Btw, do I still need ember-cli-mocha actually? Seems it only contains the blueprints nowadays, right?
There was a problem hiding this comment.
ember-cli/ember-cli-eslint#225 and code like that is the problem and the reason why we're keeping the "wrapper" for now
simonihmig
force-pushed
the
new-testing-api
branch
from
30e8da4 to
8a245c6
Compare
simonihmig
changed the title
Owner
Author
|
@andreasschacht this is now updated to the real release, and should be ready to be merged! |
andreasschacht
approved these changes
Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still WIP, as the support for the new testing APIs is not yet released in
ember-mocha(using the master branch for now). So don't merge yet!But all green it seems, so 🎉 /cc @Turbo87