Add actor= parameter to datasette.client methods#2688
Merged
Conversation
Plugins and tests can now pass actor={"id": "..."} to any datasette.client
method as a shorthand for signing a ds_actor cookie via
datasette.client.actor_cookie(). Passing both actor= and a ds_actor cookie
raises TypeError.
Also converts existing tests that went through DatasetteClient to use the
new shorthand. Tests that use the synchronous TestClient (app_client-style)
and tests that intentionally exercise the ds_actor cookie mechanism are
left unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
+ Coverage 90.81% 90.83% +0.02%
==========================================
Files 56 56
Lines 8553 8564 +11
==========================================
+ Hits 7767 7779 +12
+ Misses 786 785 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datasette.client.get(path, actor={"id": "root"}now makes the internal request with that actor asrequest.actor- same for the other HTTP verb methods ondatasette.client.Upgraded relevant tests to use the new
actor=mechanism.Documentation: https://datasette--2688.org.readthedocs.build/en/2688/internals.html#authenticating-as-an-actor
📚 Documentation preview 📚: https://datasette--2688.org.readthedocs.build/en/2688/