Replace Janus queue with asyncio.Future#2715
Merged
Merged
Conversation
Closes #1752 AI generated patch explanation: https://gisthost.github.io/?e2b8d9c7666e988b5c003ff5e5ef3098
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 57 57
Lines 8763 8776 +13
=====================================
- Misses 8763 8776 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simonw
commented
May 16, 2026
| reply_queue = janus.Queue() | ||
| loop = asyncio.get_running_loop() | ||
| reply_future = loop.create_future() | ||
| self._write_queue.put( |
Owner
Author
There was a problem hiding this comment.
Note that even though we dropped the Janus queue we still queue writes using a standard library Queue, which is created here:
datasette/datasette/database.py
Lines 379 to 383 in 46d90a0
Owner
Author
|
From the coverage report it looks like our tests don't exercise the various cases where an exception is raised during a query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
AI generated patch explanation: https://gisthost.github.io/?e2b8d9c7666e988b5c003ff5e5ef3098
📚 Documentation preview 📚: https://datasette--2715.org.readthedocs.build/en/2715/