Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sqlite_utils/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -2905,9 +2905,10 @@ def delete_where(
sql = "delete from {}".format(quote_identifier(self.name))
if where is not None:
sql += " where " + where
self.db.execute(sql, where_args or [])
if analyze:
self.analyze()
with self.db.conn:
self.db.execute(sql, where_args or [])
if analyze:
self.analyze()
return self

def update(
Expand Down
14 changes: 14 additions & 0 deletions tests/test_delete.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from sqlite_utils import Database
def test_delete_rowid_table(fresh_db):
table = fresh_db["table"]
table.insert({"foo": 1}).last_pk
Expand Down Expand Up @@ -32,6 +33,19 @@ def test_delete_where_all(fresh_db):
assert table.count == 0


def test_delete_where_all_auto_commits(db_path):
db = Database(db_path)
table = db["table"]
table.insert_all(({"id": i} for i in range(1, 6)), pk="id")
assert table.count == 5

table.delete_where()
assert table.count == 0

reopened = Database(db_path)
assert reopened["table"].count == 0


def test_delete_where_analyze(fresh_db):
table = fresh_db["table"]
table.insert_all(({"id": i, "i": i} for i in range(10)), pk="id")
Expand Down
Loading