use popstate to close and reopen colorbox when using back/forward browse...#36
Conversation
|
Just a quick heads up, _AllFiles is not the only place where you might want to go back to. Every group is appended with a _. In hindsight, I probably should have used window.onpopstate instead of the jquery library because the jquery library is a polyfill for old browsers and very few developers will probably running that version. Good PR anyways 👍. As long as one of ours get merged, I'll be happy. |
… prev_anchor is set to avoid bugs related to hitting back/forward on files in a group
|
Thanks @whatasunnyday ! I made the change you suggested, and while doing so found a bug that I fixed. Bonus! :) |
|
Which should I merge? |
|
@bf4 I don't care if its @justinsteele or mine. Since you're the maintainer, whichever is easier to maintain ;). |
|
In my completely biased view.. haha.. If no one sees any problems with this one, I'd use it as it fixes the forward button as well. |
|
Well, my POV is not having tested it, relying on both of you having verified each other's, and punting on picking between the two... :) I should add you both to the changelog but this repo doesn't have one... |
use popstate to close and reopen colorbox when using back/forward browse...
|
Shipped as part of simplecov-html 0.9.0. SimpleCov 0.9.2 with a loosened version constraint will ship in a couple minutes. Thanks @whatasunnyday and @justinsteele! |
## Bugfixes 0.9.2, 2015-02-18 ([changes](simplecov-ruby/simplecov@v0.9.1...v0.9.2)) ==================== This is a minor bugfix release for simplecov-html, released as `0.9.0`. Due to the tight version constraint in the gemspec a new release of simplecov had to be shipped to allow using simplecov-html `~> 0.9.0`. * The browser back / forward button should now work again. See [#36](simplecov-ruby/simplecov-html#36) and [#35](simplecov-ruby/simplecov-html#35). Thanks @whatasunnyday and @justinsteele for submitting PRs to fix this. * Fix "warning: possibly useless use of a variable in void context" See [#31](simplecov-ruby/simplecov-html#31). Thanks @cbandy * Always use binary file format. See [#32](simplecov-ruby/simplecov-html#32). Thanks @andy128k * Avoid slow file output with JRuby/Windows. See [#16](simplecov-ruby/simplecov-html#16). Thanks @pschambacher Other than the release includes a bunch of mostly documentation improvements: * Update Rails path for Rails 4+. See [#336](simplecov-ruby/simplecov#336). Thanks @yazinsai * Encourage use of .simplecov to avoid lost files. See [#338](simplecov-ruby/simplecov#338). thanks @dankohn * Specified in the gemspec that simplecov needs ruby 1.8.7. See [#343](simplecov-ruby/simplecov#343). thanks @iainbeeston * Fix mispointed link in CHANGELOG.md. See [#353](simplecov-ruby/simplecov#353). Thanks @dleve123 * Improve command name docs. See [#356](simplecov-ruby/simplecov#356). Thanks @gtd
4 participants
...r buttons, fixes simplecov-ruby/simplecov#263