JRuby support

[raydog153]

Jruby 1.6.4 has now added support for the ruby coverage library as seen in this closed issue ( https://jira.codehaus.org/browse/JRUBY-5935 ). When I tried simplecov when running my rspecs, at the end of the run when it is calculating the coverage, I got the following error:

SystemStackError: stack level too deep
eval at org/jruby/RubyKernel.java:1093
result at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/1.9/erb.rb:753
formatted_file_list at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/gems/1.8/gems/simplecov-html-0.5.3/lib/simplecov-html.rb:53
result at (erb):30
eval at org/jruby/RubyKernel.java:1093
result at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/1.9/erb.rb:753
format at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/gems/1.8/gems/simplecov-html-0.5.3/lib/simplecov-html.rb:19
open at org/jruby/RubyIO.java:1111
format at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/gems/1.8/gems/simplecov-html-0.5.3/lib/simplecov-html.rb:18
format! at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/gems/1.8/gems/simplecov-0.5.3/lib/simplecov/result.rb:90
at_exit at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/gems/1.8/gems/simplecov-0.5.3/lib/simplecov/configuration.rb:133
call at org/jruby/RubyProc.java:262
(root) at /home/ray/Perforce/ray_ray-desktop/ThirdParty/jruby/jruby-1.6.4/lib/ruby/gems/1.8/gems/simplecov-0.5.3/lib/simplecov/defaults.rb:42

I was able to solve this issue by removing the jruby_float_fix.rb file. After this I am able to run rspec with simplecov and get a coverage report generated. Only problem now is that the coverage report is reporting 100% coverage for everything, and I know that is not true, esp when I run only one of my spec files. I'll gladly work with you to get this working as this is high priority for us, and I cannot find any other coverage tool out there that works for jruby and 1.9. Also one more issues is that for any view that is rendered, I get this error, but only when I start simplecov:

 Failure/Error: Unable to find matching line from backtrace
 ActionView::Template::Error:
   -1
 # org.jruby.ext.coverage.CoverageData$1.eventHandler(CoverageData.java:55)
 # org.jruby.runtime.EventHook.event(EventHook.java:30)
 # org.jruby.Ruby.callEventHooks(Ruby.java:2647)
 # org.jruby.evaluator.ASTInterpreter.callTraceFunction(ASTInterpreter.java:214)
 # org.jruby.ast.NewlineNode.interpret(NewlineNode.java:100)
 # org.jruby.ast.RootNode.interpret(RootNode.java:129)
 # org.jruby.evaluator.ASTInterpreter.INTERPRET_EVAL(ASTInterpreter.java:96)
 # org.jruby.evaluator.ASTInterpreter.evalSimple(ASTInterpreter.java:198)
 # org.jruby.RubyBasicObject.evalUnder(RubyBasicObject.java:1934)
 # org.jruby.RubyBasicObject.specificEval(RubyBasicObject.java:1913)
 # org.jruby.RubyModule.module_eval(RubyModule.java:2233)
 # org.jruby.RubyModule$i$module_eval_DBG.call(RubyModule$i$module_eval_DBG.gen:65535)
 # org.jruby.internal.runtime.methods.JavaMethod$JavaMethodZeroOrOneOrTwoOrThreeOrNBlock.call(JavaMethod.java:300)

.......

[raydog153]

After some more work on this I found the problem with the 100% coverage being reported. Seems that Jruby does not indicate which lines are not code lines vs which lines are code and not run. So all code lines not run are nil in the coverage array coming back from jruby. I tried to do some modifications to the gem to detect which lines are code and set them to 0, and this partiall works, but needs more work to cover all test cases, since my simple fix doesn't work for lines of code the span across a single line. I filed a bug with JRuby to fix this, which would be the best, but not sure if that will happen. I will look more into how I can figure out what lines are valid lines of code that can be run to mark as 0 from nil. Here if the link to the JRuby bug: http://jira.codehaus.org/browse/JRUBY-6106

[colszowka]

Thanks for looking into this! Back when initial 1.9 support arrived in JRuby 1.6 RC1, I had a look into this but then realized the Coverage library was not included yet. I've removed the jruby_float_fix in the new release 0.5.4, so at least this obstacle is out of the way.

I currently don't really have time to dig further into this, but I'd gladly merge any pull requests that lead to JRuby support. From what you've explained it seems to me as if the Coverage library in JRuby needs to be brought to full compatibility with MRI's one. Working around this in SimpleCov might be possible, but I think this is something the Ruby impl needs to supply.

[colszowka]

@headius Has recently further investigated this and noted his findings in JRuby's bugtracker. Seems this isn't going to happen any time soon. Keeping this open though as a reminder to follow eventual new developments on that.

See: http://jira.codehaus.org/browse/JRUBY-6106

[colszowka]

There have recently been further changes to get this going in JRuby, see the aforementioned http://jira.codehaus.org/browse/JRUBY-6106, but it seems it does not work with SimpleCov just yet. Getting there though :)

[PragTob]

If anyone's interested, here is my updated bug report (or rather experience report) - feel free to chime in!

bug report

[rthbound]

What's the status on 1.7.0?

[PragTob]

The issue hasn't been touched since I reported my experience to the initial try by the great @headius (thanks). I'll try to give it another shot with 1.7.0.

Thought about digging into the implementation myself, but I want to do a lot of things and I guess it's hard to get into with a minimal knowledge of interpreters and JRuby itself. So don't count on me ;-)

[PragTob]

Seems to be working correctly with 1.7. Thank you so much @headius! Happy testing everyone!

[BrandonMathis]

Can I get an update on this from anyone. I'd like to test this out but I can't seem to set the debug flag.

jruby --debug -S bundle exec rake spec COVERAGE=on and bundle exec jruby --debug -S rake spec COVERAGE=on both give me the warning "tracing (e.g. set_trace_func) will not capture all events without --debug flag".

Is there something, syntactically, that I am doing wrong here?

[PragTob]

The feature shipped with jruby 1.7 and it works beautifully for us. This should be closed.

[BrandonMathis]

Is the command you are using similar to the one I posted above? I'm still getting the warning on jruby-1.7.3

confirmed issue goes away using jruby-1.7.2 built with --1.9 --disable-binary

[headius]

@BrandonMathis "bundle exec" launches a new subprocess, but does not pass along flags from the original command. Try env var JRUBY_OPTS=--debug instead.