Update http gem to 5.0.4 #2998
Merged
Update http gem to 5.0.4 #2998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get to a fixed version for arm m1 macs The latest version of the http gem drops http-parser for llhttp, which has broader compatibility, as well as including a whole host of other fixes in http itself. see https://github.com/httprb/http/blob/main/CHANGES.md for details re: #1969 re: httprb/http#630
HTTP has a built in parse method we can use, we just have to provide the content type that we are expecting see httprb/http#540
rsanheim
commented
Oct 20, 2021
| http-cookie (1.0.4) | ||
| domain_name (~> 0.5) | ||
| http-form_data (2.3.0) | ||
| http-parser (1.2.1) |
Contributor
Author
There was a problem hiding this comment.
No more http-parser!
| return unless response.status.ok? | ||
|
|
||
| JSON.parse(response, symbolize_names: true) | ||
| response.parse(:json).deep_symbolize_keys |
Contributor
Author
There was a problem hiding this comment.
The http gem has a parse method built in, which works fine, we just need to tell it to parse as json.
| around do |example| | ||
| WebMock.disallow_net_connect! | ||
| example.run | ||
| WebMock.allow_net_connect! |
Contributor
Author
There was a problem hiding this comment.
This made tracking down spec failures easier, because our suite defaults to this being allowed for feature specs to work.
timcheadle
approved these changes
Oct 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to upgrade to a version that works with M1 ARM macs.
The latest version of the http gem drops
http-parserforllhttp, which has broader compatibility and works fine out of the box on ARM. The 5.0.4 version ofhttpalso includes many other fixes that we should update for.See https://github.com/httprb/http/blob/main/CHANGES.md for details on the update. This requires one small change in our Exotel API calls to properly handle JSON responses -- otherwise the rest of the changes are spec changes.
(this is probably the better alternative to #2997, because we should be on the latest version of the http gem anyways)
/cc @abnios
re: #1969
re: httprb/http#630