[SCIM] Missing refs on subsequent users

[FlorianTusek]

I found a bug in 5.0.3.

Missing refs on subsequent users

Scenario:

Group A is member of Group B
Group B is member of Group C
Group C is member of Group D
Group D is member of Group E
User 1 is member of Group A

Add User 2 to Group A

• with either:
  • PUT
  • PATCH add
  • PATCH replace

User 1 has groups [Group A, Group B, Group C, Group D]
User 2 has groups [Group A]
But User 2 should have the same groups as User 1.

[simpleidserver]

Hello,

An incorrect attribute was indeed used to propagate the information. :(
The issue has been fixed in the master branch.

KR,
SID

[FlorianTusek]

This works great.

I still found another missing propagation.

Scenario:

Group B is member of Group C
Group C is member of Group D
User is member of Group A

Add Group A to Group B

• with either:
  • PUT
  • PATCH add
  • PATCH replace

User has groups [Group A, Group B]
User should have groups [Group A, Group B, Group C, Group D]

[simpleidserver]

Sorry for the late reply, and thank you for reporting this bug! The issue has been fixed in the master branch.

[FlorianTusek]

No problem, I still consider your reply and fix as being really fast.

I found another bug:

Scenario:

Group B is member of Group C
User 1 is member of Group B
User 2 is member of Group A

Add Group A to Group B

• with either:
  • PUT
  • PATCH add
  • PATCH replace

User 1 has groups [Group B, Group B, Group C]
Group B should not be in there twice.

PATCH remove User 1 from Group B
User 1 has groups [Group B]
User 1 should not have any Group

[simpleidserver]

The issue has been fixed in the master branch :) The algorithm used to resolve the children was incorrect :(