Fixed state not being reset to correct value when transitioning out #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dardalan
force-pushed
the
fix/transition-animation
branch
from
2f3c4a7 to
65fa846
Compare
dardalan
commented
Aug 19, 2021
| parentElement = parentElement.parentElement | ||
| parentElement = parentElement.parentElement; | ||
|
|
||
| if (isTesting() && parentElement === null) { |
Member
Author
There was a problem hiding this comment.
Not sure exactly why but will-destroy modifier (https://github.com/cibernox/ember-basic-dropdown/blob/master/addon/templates/components/basic-dropdown-content.hbs#L30) is getting called in the template after the parent node has been removed from the DOM. Looks like it's only related to Test env.
Related Issues:
emberjs/ember.js#18795
dardalan
changed the title
tylerturdenpants
approved these changes
Aug 23, 2021
dardalan
force-pushed
the
fix/transition-animation
branch
from
1434264 to
db1268b
Compare
alex-konoval
approved these changes
Aug 23, 2021
Member
|
Looks like this is still failing... |
dardalan
force-pushed
the
fix/transition-animation
branch
4 times, most recently
from
e8c5f37 to
06c3828
Compare
dardalan
force-pushed
the
fix/transition-animation
branch
from
06c3828 to
fa746c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already opened pr on this Issue cibernox#623
Hopefully Fixes cibernox#615 🤞
but i am not sure we should make any changes on this code (https://github.com/cibernox/ember-basic-dropdown/pull/623/files#diff-5eb8bde405ea618cba05ea05b9898dc60ff96ac459a953c279fbb24f39a46f81L128-L132), cause on production code it works good, the only problem with tests, so i made a workaround for testing purpose. Any idea how to fix this issue better, very welcome.
The transitioning--in etc classes don't get reset after the first render. When the dropdown content first renders, it animates correctly, but on subsequent renders there is no animation - cause state not being reset to correct value.
Looks like it was broken here in this commit, so idea to revert back and cover with tests:
cibernox@1819c01#diff-73297f8c71645544a2a6826e5c3146aff7cb2333d9c17fe968258e5f14dc4a79R164