Skip to content

React Query Option #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminreid merged 21 commits into from
Oct 7, 2020
Merged

React Query Option #128

benjaminreid merged 21 commits into from
Oct 7, 2020

Conversation

@benjaminreid
Copy link
Contributor

@benjaminreid benjaminreid commented Oct 7, 2020 •
edited
Loading

Proposed changes

Add an option to use react-query instead of the redux-saga and reducer setup.

Also addresses

  • removes extra configuration for react-navigation (Java file and gradle modifications), it’s no longer needed
  • changes instructions in README to use the official TypeScript template
  • ...thus, no need to remove the .flowconfig, this instructions is removed
  • add an example env
  • fix some files that were attempting to be deleted as .js files, which are now .tsx
  • switch to using npx pod-install to handle installing pods after running init
  • changes default types for styled-components
  • adds TS support for styled-components
  • add example of react-query to the styleguide

Checklist

  • Read the contributing guidelines
  • Update the README.md if you think it’s necessary
  • Make sure the documentation reflects the changes you’ve made

@benjaminreid benjaminreid self-assigned this Oct 7, 2020
@benjaminreid benjaminreid marked this pull request as ready for review October 7, 2020 15:29
@benjaminreid benjaminreid merged commit e18f8cc into master Oct 7, 2020
@benjaminreid benjaminreid deleted the react-query-option branch October 7, 2020 16:24
craigcoles added a commit that referenced this pull request Oct 16, 2020
@craigcoles
Merge branch 'master' into fastlane
5e063c2 
* master:
  📝 Update references to romulus-cli from previous project codename
  Remove original issue template
  Update issue templates
  Bump version
  React Query Option (#128)
  Bump lodash from 4.17.15 to 4.17.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@craigcoles craigcoles craigcoles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminreid benjaminreid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjaminreid @craigcoles