Upgrade to Brod 4.4.1. Remove the remaining cheater test sleeps. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kafka_protocol and crc32er. Remove the remaining cheater test sleeps.
nathanmonteleone
requested review from
LiruMouse,
ctcline-simplifi and
joshuawscott
as code owners
|
Sorry for closing that one. Got myself turned around there and forgot we hadn't gotten the tag for it yet. |
Author
|
@ctcline-simplifi no worries, I'll reopen it... for all of two seconds 😆 |
ctcline-simplifi
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brod 4.4.1 has some stricter requirements for its dependencies, hence the updates to kafka_protocol and crc32cer in mix.lock.
This includes Cristina's fix to use handle_continue instead of self-messages sent from init, in a couple of the brod genservers.
https://simplifi.atlassian.net/browse/INT-11108 (I realize this is closed, but this is to my knowledge the final step of that story.)