Use packages for individual watchers/executioners #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| package executioner | |||
| package log | |||
Member
There was a problem hiding this comment.
Maybe we should name this logger or logging so that it doesn't have the same name as a built in basic package (that we are actually including part of)
| @@ -1,4 +1,4 @@ | |||
| package watcher | |||
| package time | |||
Member
There was a problem hiding this comment.
ok, now you're just trolling.
Contributor
Author
There was a problem hiding this comment.
Yeah... I put those names in as placeholders and planned to swap them out, but forgot. Thanks for the reminder. I'll rename them 🤣
Member
joshuawscott
left a comment
joshuawscott
left a comment
There was a problem hiding this comment.
Only comments I have are the confusing/conflicting package names, otherwise LGTM
joshuawscott
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-5526
I think this is the last of the cleanup PRs. Just wanted to move the executioner and watcher implementations into their own packages. This will make it more organized as I add more in subsequent PRs.