Add ShellExecutioner #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjonesy
commented
Sep 11, 2024
Comment on lines
+46
to
+68
| // Command is required and must be a string | ||
| if command, ok := cfgMap["command"].(string); ok { | ||
| if command == "" { | ||
| return nil, fmt.Errorf("command must not be empty") | ||
| } | ||
| cfg.Command = command | ||
| } else if cfgMap["command"] != nil { | ||
| return nil, fmt.Errorf("command must be a string") | ||
| } else { | ||
| return nil, fmt.Errorf("command is required") | ||
| } | ||
|
|
||
| // If shell is set, it should be a string | ||
| if cfgMap["shell"] != nil { | ||
| if shell, ok := cfgMap["shell"].(string); ok { | ||
| if shell == "" { | ||
| return nil, fmt.Errorf("shell must not be empty") | ||
| } | ||
| cfg.Shell = shell | ||
| } else if cfgMap["shell"] != nil { | ||
| return nil, fmt.Errorf("shell must be a string") | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
In the near future I'm planning to generalize the config parsing into a utility package we can re-use.
| DataEnvVarName = "GOVERSEER_DATA" | ||
|
|
||
| // DefaultShell is the default shell to use when executing a command | ||
| DefaultShell = "/bin/sh" |
Member
There was a problem hiding this comment.
I like how we're going to deprive people of bash if they don't pass it in 😂
joshuawscott
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-5526
This PR adds a new Shell Executioner
This executioner will run the configured command in a shell.
The data that triggered the change is written to a temporary work directory that the command can access, should it need the data in it's logic. The path to this file is stored in the
GOVERSEER_DATAenvironment variable, which is added to the command's environment. I chose to write this data to disk as the size of the data could easily exceed what we can store in an environment variable.