Skip to content

adora84#4

Open
kalaaji wants to merge 5 commits intosimplonco:masterfrom
kalaaji:master
Open

adora84#4
kalaaji wants to merge 5 commits intosimplonco:masterfrom
kalaaji:master

Conversation

@kalaaji
Copy link
Copy Markdown

@kalaaji kalaaji commented Apr 21, 2016

No description provided.

@yvan-sraka
Copy link
Copy Markdown
Contributor

yvan-sraka commented Apr 21, 2016

Try again 😄 !
You have to take the time to check the logs:
https://travis-ci.org/simplonco/leap/builds/124776288

$ npm install jasmine-node
$ jasmine-node *.spec.js --verbose --captureExceptions
Exception loading: /home/travis/build/simplonco/leap/leap.spec.js
[ReferenceError: Year is not defined]

Comment thread leap.js Outdated
*/
function Year(year) {
this.year = year;
var YearLeap = function(year) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad 😞 .. you have to write your code in:

Year.prototype.isLeap = function () {
//
// YOUR CODE GOES HERE
// (you have to use this.year)
//
}

@yvan-sraka yvan-sraka changed the title first try adora84 Apr 22, 2016
Comment thread leap.js
}

YearLeap(2000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAAAAAAT 😨 !
Why do you remove that ???

Comment thread q Outdated
@@ -0,0 +1,14 @@
[core]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hummmmm 😬 ..
Maybe you don't want to share your .git/config file renamed as a q file?

@yvan-sraka
Copy link
Copy Markdown
Contributor

CONGRATULATIONS 🎉 !

Comment thread leap.js
* Whether given year is a leap year.
*/
Year.prototype.isLeap = function () {
return (this.year % 4 === 0 && this.year % 100 === 0 || this.year % 400 === 0);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 😎 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants