amare16 #1
Open
amare16 wants to merge 13 commits intosimplonco:masterfrom
amare16:master
Open
Conversation
Contributor
|
Oups.. I forget to enable Travis CI on this repository, now if you push a commit (like just adding a comment), it will work 😉 ! |
Author
|
Here in github comment place or on terminal? |
Contributor
|
No, in your files, to do a new "fake" commit 😄 ! |
Contributor
|
Check Travis CI logs: https://travis-ci.org/simplonco/php-hello-world/builds/143839706 😉! |
Contributor
|
Hint: if you want automated tests working, you have to send only a PHP function without all your HTML test code 😄! |
| @@ -0,0 +1,8 @@ | |||
| body { | |||
Contributor
There was a problem hiding this comment.
You can remove this file and the cute image, which are now useless 😉!
Contributor
|
Read comments I left for you ❤️! |
Author
|
What is the problem? it is working on online checker. |
| // This is only a SKELETON file for the "Hello World" exercise. | ||
| // It's been provided as a convenience to get you started writing code faster. | ||
| // | ||
| function helloWorld($name) { |
Contributor
There was a problem hiding this comment.
Try function helloWorld($name = "") 😉!
Contributor
|
CONGRATULATIONS ☀️! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.