-
Notifications
You must be signed in to change notification settings - Fork 1
sakhradam #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sakhradam
wants to merge
3
commits into
simplonco:master
Choose a base branch
from
sakhradam:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
sakhradam #1
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,22 @@ | ||
| #!/usr/bin/env ruby | ||
| gem 'minitest', '>= 5.0.0' | ||
| require 'minitest/autorun' | ||
| require_relative 'leap' | ||
|
|
||
| # Test data version: | ||
| # deb225e Implement canonical dataset for scrabble-score problem (#255) | ||
|
|
||
| class Date | ||
| def leap? | ||
| throw "Implement this yourself instead of using Ruby's implementation." | ||
| end | ||
|
|
||
| alias gregorian_leap? leap? | ||
| alias julian_leap? leap? | ||
| end | ||
|
|
||
| class YearTest < Minitest::Test | ||
| def test_leap_year | ||
| assert Year.leap?(1996), '' | ||
| end | ||
|
|
||
| def test_standard_and_odd_year | ||
| skip | ||
| refute Year.leap?(1997), '' | ||
| end | ||
|
|
||
| def test_standard_even_year | ||
| skip | ||
| refute Year.leap?(1998), '' | ||
| end | ||
| require 'minitest/autorun' | ||
| require_relative 'year' | ||
|
|
||
| def test_standard_nineteenth_century | ||
| skip | ||
| refute Year.leap?(1900), '' | ||
| class YearTest < MiniTest::Unit::TestCase | ||
| def test_vanilla_leap_year | ||
| assert Year.new(1996).leap? | ||
| end | ||
|
|
||
| def test_standard_eighteenth_century | ||
| skip | ||
| refute Year.leap?(1800), '' | ||
| def test_any_old_year | ||
| assert !Year.new(1997).leap? | ||
| end | ||
|
|
||
| def test_leap_twenty_fourth_century | ||
| skip | ||
| assert Year.leap?(2400), '' | ||
| def test_century | ||
| assert !Year.new(1900).leap? | ||
| end | ||
|
|
||
| def test_leap_y2k | ||
| skip | ||
| assert Year.leap?(2000), '' | ||
| def test_exceptional_century | ||
| assert Year.new(2000).leap? | ||
| end | ||
|
|
||
| # Problems in exercism evolve over time, as we find better ways to ask | ||
| # questions. | ||
| # The version number refers to the version of the problem you solved, | ||
| # not your solution. | ||
| # | ||
| # Define a constant named VERSION inside of the top level BookKeeping | ||
| # module. | ||
| # In your file, it will look like this: | ||
| # | ||
| # module BookKeeping | ||
| # VERSION = 1 # Where the version number matches the one in the test. | ||
| # end | ||
| # | ||
| # If you are curious, read more about constants on RubyDoc: | ||
| # http://ruby-doc.org/docs/ruby-doc-bundle/UsersGuide/rg/constants.html | ||
|
|
||
| def test_bookkeeping | ||
| skip | ||
| assert_equal 2, BookKeeping::VERSION | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| class Year | ||
|
|
||
| def initialize(value) | ||
| @value = value | ||
| end | ||
|
|
||
| def leap? | ||
| divisble_by?(4) and (!divisble_by?(100) or divisble_by?(400)) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| attr_reader :value | ||
|
|
||
| def divisble_by?(divisor) | ||
| (value % divisor) == 0 | ||
| end | ||
|
|
||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait wait wait!
You change the test file, really 😮?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol just i anted to test something ...but not to pass the exercise :)
On Fri, Jun 3, 2016 at 11:02 AM, Yvan Sraka notifications@github.com
wrote: