Merged
Conversation
5d2751a to
171b220
Compare
171b220 to
bbdb5af
Compare
mxsrc
requested changes
Mar 6, 2026
Collaborator
mxsrc
left a comment
There was a problem hiding this comment.
Looks largely good, I have quite a few comments but they are all very localized changes.
Collaborator
|
Great, thanks for the changes. None of the changes should change any semantics, but I think it's still worth testing again to ensure everything works as intended. |
Member
Author
|
sure, yeah, I think it worth to redo the tests |
Member
Author
|
did a quick a test looks good and able to perform restore to a timestamp |
mxsrc
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements restore functionality of point in time recovery.
The architecture diagram is as follows:
The backup is picked up automatically. For the given input timestamp, backup1 is picked up for recovery