Skip to content

Add new railcars: Škoda 71E & Newag 36WEd#132

Open
fm-mf wants to merge 2 commits intosimrail:mainfrom
fm-mf:new_railcars
Open

Add new railcars: Škoda 71E & Newag 36WEd#132
fm-mf wants to merge 2 commits intosimrail:mainfrom
fm-mf:new_railcars

Conversation

@fm-mf
Copy link
Copy Markdown

@fm-mf fm-mf commented Apr 7, 2026

Adding new railcars from the two recent DLCs

Summary by CodeRabbit

  • New Features
    • Added Škoda Plzeň locomotive (model 163) to the railcar collection.
    • Added Newag electric multiple unit (model 36WEd) to the railcar collection.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 364dcfb6-364e-4140-bd7b-7280876c9fcd

📥 Commits

Reviewing files that changed from the base of the PR and between 41068d7 and c53a731.

⛔ Files ignored due to path filters (25)
  • packages/map/public/trains/163_021-9.png is excluded by !**/*.png
  • packages/map/public/trains/163_029-2.png is excluded by !**/*.png
  • packages/map/public/trains/163_030-0.png is excluded by !**/*.png
  • packages/map/public/trains/163_034-2.png is excluded by !**/*.png
  • packages/map/public/trains/163_035-9.png is excluded by !**/*.png
  • packages/map/public/trains/163_040-9.png is excluded by !**/*.png
  • packages/map/public/trains/163_041-7.png is excluded by !**/*.png
  • packages/map/public/trains/163_042-5.png is excluded by !**/*.png
  • packages/map/public/trains/163_043-3.png is excluded by !**/*.png
  • packages/map/public/trains/163_045-8.png is excluded by !**/*.png
  • packages/map/public/trains/163_046-6.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-001.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-002.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-003.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-004.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-005.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-006.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-007.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-008.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-009.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-010.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-011.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-012.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-013.png is excluded by !**/*.png
  • packages/map/public/trains/36wed-014.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • packages/map/components/railcars.json

📝 Walkthrough

Walkthrough

New railcar definitions added to the railcar catalog JSON file. The changes include locomotive entries for designation 163 (Škoda Plzeň) and electric multiple unit entries for designation 36WEd (Newag), each with distinct IDs and shared physical specifications. No existing data was modified.

Changes

Cohort / File(s) Summary
Railcar Data Additions
packages/map/components/railcars.json
Added locomotive entries (designation 163, Škoda Plzeň, typeIdentifier 71E) and electric multiple unit entries (designation 36WEd, Newag, typeIdentifier 36WEd) with distinct id/apiName values and corresponding physical/specification attributes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Choo-choo, all aboard the JSON track,
New trains are rolling, they're stacked in back!
Locomotives and units, both shiny and bright,
The railcar collection's growing tonight! 🚂✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically identifies the main change: adding two new railcar types (Škoda 71E and Newag 36WEd) to the railcars configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant