Skip to content

chore: identify points by name#108

Merged
derklaro merged 1 commit intomainfrom
points-by-name
Apr 12, 2026
Merged

chore: identify points by name#108
derklaro merged 1 commit intomainfrom
points-by-name

Conversation

@derklaro
Copy link
Copy Markdown
Member

@derklaro derklaro commented Apr 12, 2026

Timetables are currently being updated, which also includes that point ids no longer identify a point. Some placeholder points now use random ids. To circumvent that, we need to identify points by their name instead of the point id.

@github-actions
Copy link
Copy Markdown

Test Results

93 tests  ±0   88 ✅ ±0   42s ⏱️ +3s
18 suites ±0    4 💤 ±0 
18 files   ±0    1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 50ed882. ± Comparison against base commit 6fdfc7d.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
tools.simrail.backend.common.point.SimRailPointProviderTest ‑ testAllSimRailPointIdsAreOnlyAssociatedOnce()
tools.simrail.backend.common.point.SimRailPointProviderTest ‑ testFindPointBySimRailPointId()
tools.simrail.backend.common.point.SimRailPointProviderTest ‑ testAllPointNamesAreOnlyAssociatedOnce()
tools.simrail.backend.common.point.SimRailPointProviderTest ‑ testFindPointByAlternativeName()

@derklaro derklaro merged commit c33923b into main Apr 12, 2026
1 of 5 checks passed
@derklaro derklaro deleted the points-by-name branch April 12, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant