improvement(sub flow): adding clamps for subflow drag and drops of blocks#2460
Merged
Pbonmars-20031006 merged 1 commit intostagingfrom Dec 18, 2025
Merged
improvement(sub flow): adding clamps for subflow drag and drops of blocks#2460Pbonmars-20031006 merged 1 commit intostagingfrom
Pbonmars-20031006 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR fixes a UI positioning bug where blocks dropped inside loop containers weren't being positioned correctly. The fix introduces position clamping to ensure blocks stay fully inside container boundaries. Key changes:
Minor style issue:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Workflow
participant NodeUtilities
participant ClampFunction
participant BlocksStore
Note over User,BlocksStore: Block Drop Scenario
User->>Workflow: Drop block onto loop container
Workflow->>Workflow: Calculate raw position relative to container origin
Workflow->>NodeUtilities: estimateBlockDimensions(blockType)
NodeUtilities-->>Workflow: {width, height}
Workflow->>ClampFunction: clampPositionToContainer(rawPosition, containerDimensions, blockDimensions)
ClampFunction->>ClampFunction: Calculate content area bounds (minX, minY, maxX, maxY)
ClampFunction->>ClampFunction: Clamp x and y to keep block inside
ClampFunction-->>Workflow: Clamped position
Workflow->>BlocksStore: Add block with clamped position
Note over User,BlocksStore: Block Drag Scenario
User->>Workflow: Drag block inside container
Workflow->>Workflow: onNodeDragStop triggered
Workflow->>Workflow: Check if block has parentId
alt Block is inside container
Workflow->>BlocksStore: Get current block and parent info
Workflow->>ClampFunction: clampPositionToContainer(node.position, containerDimensions, blockDimensions)
ClampFunction-->>Workflow: Clamped final position
Workflow->>Workflow: collaborativeUpdateBlockPosition(nodeId, finalPosition)
else Block is at root level
Workflow->>Workflow: collaborativeUpdateBlockPosition(nodeId, node.position)
end
Workflow->>Workflow: Record move history
|
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-node-utilities.ts, line 193-195 (link)style: hardcoded magic numbers instead of using
CONTAINER_DIMENSIONSconstantsNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
6 files reviewed, 1 comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing the loop sub flow UI issue where dropping a block on top of loop block wouldn't position it appropriately on the UI.
Type of Change
Testing
Tested Manually.
Checklist