Validation checks for run input

[AbyAbraham21]

Basic checks for data types passed into run.init() based on pydantic models defined in models.py

[alahiff]

I think using instead here:

            self._error(e)

rather than:

            self._error(json.dumps(e.json()))

makes things much easier to understand. Using json you get an error like this:

RuntimeError: "[\n  {\n    \"loc\": [\n      \"metadata\",\n      \"hello\"\n    ],\n    \"msg\": \"str type expected\",\n    \"type\": \"type_error.str\"\n  },\n  {\n    \"loc\": [\n      \"metadata\",\n      \"hello\"\n    ],\n    \"msg\": \"value is not a valid integer\",\n    \"type\": \"type_error.integer\"\n  },\n  {\n    \"loc\": [\n      \"metadata\",\n      \"hello\"\n    ],\n    \"msg\": \"value is not a valid float\",\n    \"type\": \"type_error.float\"\n  }\n]"

whereas with plain text you get:

RuntimeError: 3 validation errors for RunInput
metadata -> hello
  str type expected (type=type_error.str)
metadata -> hello
  value is not a valid integer (type=type_error.integer)
metadata -> hello
  value is not a valid float (type=type_error.float)

For me at least this is easier to understand.

[AbyAbraham21]

Yes, agreed. Will update.

[alahiff]

If possible we should also delete the lines:

        if not folder.startswith('/'):
            self._error('the folder must begin with /')

and update models.py to check for this instead. I noticed that if you specify something weird as the folder, e.g. a dict, the above gives an error (as expected).

[alahiff]

Updating models to have this seems to work:

    folder: constr(regex=r'^/.*')

[alahiff]

This may help with the "error": https://stackoverflow.com/questions/64909849/syntax-error-with-flake8-and-pydantic-constrained-types-constrregex