Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change log

## v0.10.1

* The worker process now no longer gives a long delay when a run has finished (now at most ~1 second).
* The worker process ends when the `Run()` context ends or `close` is called, rather than only when the main process exits.

## v0.10.0

* The `client` class can now be used to retrieve runs.
Expand Down
2 changes: 1 addition & 1 deletion simvue/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
from simvue.client import Client
from simvue.handler import Handler
from simvue.models import RunInput
__version__ = '0.10.0'
__version__ = '0.10.1'
6 changes: 5 additions & 1 deletion simvue/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def __enter__(self):

def __exit__(self, type, value, traceback):
if self._name and self._status == 'running':
self._shutdown_event.set()
if not type:
self.set_status('completed')
else:
Expand Down Expand Up @@ -203,8 +204,10 @@ def _start(self, reconnect=False):

self._metrics_queue = multiprocessing.Manager().Queue(maxsize=self._queue_size)
self._events_queue = multiprocessing.Manager().Queue(maxsize=self._queue_size)
self._shutdown_event = multiprocessing.Manager().Event()
self._worker = Worker(self._metrics_queue,
self._events_queue,
self._shutdown_event,
self._uuid,
self._name,
self._url,
Expand Down Expand Up @@ -659,8 +662,9 @@ def close(self):
if not self._active:
self._error('Run is not active')
return False

self.set_status('completed')
self._shutdown_event.set()

def set_folder_details(self, path, metadata={}, tags=[], description=None):
"""
Expand Down
7 changes: 4 additions & 3 deletions simvue/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,12 @@ def update_processes(parent, processes):


class Worker(threading.Thread):
def __init__(self, metrics_queue, events_queue, uuid, run_name, url, headers, mode, pid, resources_metrics_interval):
def __init__(self, metrics_queue, events_queue, shutdown_event, uuid, run_name, url, headers, mode, pid, resources_metrics_interval):
threading.Thread.__init__(self)
self._parent_thread = threading.currentThread()
self._metrics_queue = metrics_queue
self._events_queue = events_queue
self._shutdown_event = shutdown_event
self._run_name = run_name
self._uuid = uuid
self._url = url
Expand Down Expand Up @@ -144,11 +145,11 @@ def run(self):
pass
buffer = []

if not self._parent_thread.is_alive():
if self._shutdown_event.is_set() or not self._parent_thread.is_alive():
if self._metrics_queue.empty() and self._events_queue.empty():
sys.exit(0)
else:
counter = 0
while counter < POLLING_INTERVAL and self._parent_thread.is_alive():
while counter < POLLING_INTERVAL and not self._shutdown_event.is_set() and self._parent_thread.is_alive():
time.sleep(1)
counter += 1