-
Notifications
You must be signed in to change notification settings - Fork 1
General fixes for v2.0.0a1 #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 19, 2025
kzscisoft
requested changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of fixes for v2.0.0 found when testing the integrations repo against v2.0.0a0, and also addressing some issues found by Andrew. Main bug fixes are:
log_metricsgives an exception whentimestampis specified #702runtimeattribute to RunObjectfrom_runmethod toArtifactswhich uses/run/run_id/artifactsendpoint so thatcategoryhas an effect and improved tests to catch this case: Category parameter has no effect in client.get_artifacts_as_files #687setLevelfromdispatchso that DEBUG logs arent spammed to console: DEBUG log messages from factory being spammed to console #689nameprovided: Offline mode breaks if no run name provided #699/apifrom the end: Link printed to console is incorrect #690Don't merge until other PRs have gone in, and double check that
from_runmethod is inArtifactsbefore merging due to some cherry picking mistakes