FIx codecarbon and improve test #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to the CodeCarbon API means that the output values will need to be computed in a different manner. Delta emissions will need to be derived if needed.
kzscisoft
requested changes
Feb 28, 2025
Collaborator
kzscisoft
left a comment
kzscisoft
left a comment
There was a problem hiding this comment.
Please verify tests are passing locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges Aby's changes to fix codecarbon, along with fix to set 'api call interval' to 1, and improvement to tests
Also adds support for emissions tracking in offline mode (previously itd just hang forever while trying to contact a server)
Closes #733 #732