Target Node.js 18, expose options, gracefully handle errors#7
Open
tommy-mitchell wants to merge 2 commits intosindresorhus:mainfrom
Open
Target Node.js 18, expose options, gracefully handle errors#7tommy-mitchell wants to merge 2 commits intosindresorhus:mainfrom
tommy-mitchell wants to merge 2 commits intosindresorhus:mainfrom
Conversation
tommy-mitchell
commented
Feb 27, 2024
Comment on lines
+52
to
+54
| if (error instanceof PackageNotFoundError || error instanceof VersionNotFoundError) { | ||
| console.error(`${logSymbols.error} ${error.message}.`); | ||
| process.exitCode = 1; |
Author
There was a problem hiding this comment.
Realized it's easier to just use the verbiage from package-json here - could maybe do a quick update on package-json-cli to do the same.
tommy-mitchell
commented
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--registry-urland--no-deprecatedand handlespackage-jsonerrors:Blocker: sindresorhus/package-json#82