feat: rewrite

[sindrip]

No description provided.

[sindrip]

Code review

Found 3 issues:

1. Regression: basename(root) reverses bugfix from commit 00480a7 in add.ts and remove.ts. Commit 00480a7 ("fix: set fetch and derive repo name") specifically fixed a bug where workspace files were named after the local directory instead of the remote repo name. The rewrite reverts to basename(root), which means add and remove will write to a different .code-workspace file than the one clone created (which correctly uses the passed name). This causes workspace file corruption in normal usage when the local directory name differs from the repo name.

git-witty/src/commands/add.ts

Lines 13 to 15 in 13c6334

	.quiet();
	await syncWorkspace(root, basename(root));
	}

git-witty/src/commands/remove.ts

Lines 8 to 10 in 13c6334

	await git.worktree("remove", branch);
	await syncWorkspace(root, basename(root));
	}

2. join(branch) in add.ts is a no-op -- join("foo") returns "foo". The old code used join(root, branch) to produce an absolute path. git worktree add <path> resolves the path relative to cwd, not relative to the -C directory. When called from a nested subdirectory (which add.test.ts explicitly tests), the worktree will be created in the wrong location.

git-witty/src/commands/add.ts

Lines 6 to 9 in 13c6334

	const git = await new Git().root();
	const root = await git.rootDir();
	await git.worktree("add", join(branch));
	await git

3. Workspace file creation test deleted with no replacement. The test "clone creates a workspace file" was removed from clone.test.ts and no test anywhere verifies that syncWorkspace produces a correctly named or correctly populated .code-workspace file. Combined with issue feat: add/remove/code-workspaces #1 above, the basename(root) regression is now undetectable by tests.

https://github.com/sindrip/git-witty/blob/13c63340e38d59132b4a77b418b99b8ea7462c99/src/commands/clone.test.ts#L1-L65

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}