Skip to content

Feature: Add DockerImage classes for docker.io, nvcr.io, and quay.io#483

Open
georgiastuart wants to merge 2 commits into
singularityhub:mainfrom
georgiastuart:feature/add-metadata-fetch-override
Open

Feature: Add DockerImage classes for docker.io, nvcr.io, and quay.io#483
georgiastuart wants to merge 2 commits into
singularityhub:mainfrom
georgiastuart:feature/add-metadata-fetch-override

Conversation

@georgiastuart
Copy link
Copy Markdown
Contributor

Corresponds with singularityhub/singularity-hpc#697 . Resolves #480 and #481.

Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Signed-off-by: Georgia Stuart <georgia.stuart@gmail.com>
Copy link
Copy Markdown
Member

@vsoch vsoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! You are two steps ahead! 🙌

Do you know why the digests are sometimes taking up two lines? I think likely we would want the newline removed - I am not sure what kind of funny business it will cause.

@georgiastuart
Copy link
Copy Markdown
Contributor Author

@vsoch I figured out the two line issue: when a line goes over 80 chars, the digest gets put on the next line. It doesn't appear to cause problems (it's been present for a while), but increasing line length to 120 solves this in all but extreme cases: singularityhub/singularity-hpc@f67c7a8

120 feels pretty wide, but since these files aren't meant to be hand-edited a whole lot it's probably OK. Thoughts? 100 would likely get most tags but won't have as much breathing room.

@vsoch
Copy link
Copy Markdown
Member

vsoch commented May 11, 2026

I would say set it to a very large value to prevent line wrapping, e.g., 4096. Is there any drawback?

@georgiastuart
Copy link
Copy Markdown
Contributor Author

The main drawback is the line length is universal for the written file. So if there's a long description or something, it won't wrap. If that's not an issue, I'll set it to 4096!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address dockerhub pull limit from clobbering files

2 participants