Warning issued for %files targets

[Flamefire]

Expected Behavior

No warning

Actual Behavior

Warning if target of copy does not exist

Line:

singularity-cli/spython/main/parse/docker.py

Line 213 in 7893bdd

bot.warning("%s doesn't exist, ensure exists for build" %path)

Possible Fix

Show warning only for the "source" part. Checking the destination simply makes no sense

[vsoch]

It would make sense if the user is trying to copy a file/folder to a destination that doesn't exist (and you are right there is a bug that we don't check that). What about a slight alternative where we look for the file existing OR the directory - the logic being to copy a folder or files to some spot, the parent directory needs to exist. I propose something like:

            # Warning if doesn't exist
            if not os.path.exists(path) and not os.path.exists(os.path.dirname(path)):
                bot.warning("%s doesn't exist, ensure exists for build" %path)

Thoughts?

[Flamefire]

It does not make sense at all to check the existence of (part of) destination path
The destination is inside the container. It cannot exist

Or am I missing anything?

[vsoch]

Yeah you’re right - I’m not thinking clearly about this. I’ll update the PR in a bit.

[vsoch]

Just updated the PR.