spython replaces variables with USER in the name..

[slash5toaster]

Expected Behavior

spython should ignore variables with USER in them (e.g. $NB_USER) and only replace lines starting with USER

Actual Behavior

USER joe is replaced with su - joe
Lines like
RUN chown -cR $NB_USER /path/ get replaced with
su - # chown -cR $NB_USER /path/

Steps to Reproduce

Create a docker file, and a variable $TEST_USER
Run spython -d recipe Dockerfile Singularity.def

Context

[provide more detailed introduction to the issue itself . This is for make a reproducible issue.]

• Operating System: CentOS 7 & Mac OS 13.4
• singularity version: n/a
• spython version: 0.0.79
• python version: 3.7.4 & 3.8.2

Failure Logs

recipes.zip
spython.log

Possible Fix

[ the suggest fixes or reasons for the bug]

[vsoch]

Totally agree, that's a bug! Thank you for reporting :) Would you care to test this fix? #159

[vsoch]

Just to let you know I'm going for a quick run - I'll be back in a bit!

[slash5toaster]

That seems to fix it !!
Thanks

(venv3) intel_lic_server ( spython_test 0S-1U ) % spython -d recipe Dockerfile Singularity.def 2>&1 | tee spython.log
(venv3) intel_lic_server ( spython_test 0S-1U ) % more spython.log 
DEBUG Logging level DEBUG
DEBUG Singularity Python Version: 0.0.80
DEBUG [in]  FROM centos:7
DEBUG FROM centos:7
DEBUG [in]  ARG INTEL_PORT=27009
WARNING ARG is not supported for Singularity! To get INTEL_PORT=27009
WARNING in the container, on host export SINGULARITY_INTEL_PORT=27009
DEBUG [in]  ENV INTEL_ROOT=opt/intel \
DEBUG [in]      INTEL_VERSION=2.10.0.016 \
DEBUG [in]      INTEL_USER=rsiapp
DEBUG [in]  RUN groupadd ${INTEL_USER}    -g 451
DEBUG [in]  RUN useradd ${INTEL_USER}     -u 451    -g ${INTEL_USER}
DEBUG [in]  RUN pwck -s \
DEBUG [in]    ; grpck -s
DEBUG [in]  RUN    yum makecache fast \
DEBUG [in]      && yum install -y \
DEBUG [in]             net-tools \
DEBUG [in]             redhat-lsb \
DEBUG [in]             wget \
DEBUG [in]      && yum update -y \
DEBUG [in]      && yum clean all
DEBUG [in]  COPY ${INTEL_ROOT} /${INTEL_ROOT}
WARNING ${INTEL_ROOT} doesn't exist, ensure exists for build
DEBUG [in]  COPY usr/local/bin/run_licserver.sh /usr/local/bin/
DEBUG [in]  RUN mkdir -vp /${INTEL_ROOT}/serverlicenses /${INTEL_ROOT}/licenses \
DEBUG [in]      && chown -cR ${INTEL_USER}.${INTEL_USER} /${INTEL_ROOT} \
DEBUG [in]      && mkdir -vp /usr/local/flexlm/ \
DEBUG [in]      && ln -sv /${INTEL_ROOT}/licenses /usr/local/flexlm/licenses/
DEBUG [in]  ENV PATH=$PATH:/${INTEL_ROOT}/licenseserver
DEBUG [in]  WORKDIR /${INTEL_ROOT}
DEBUG [in]  EXPOSE ${INTEL_PORT}
DEBUG [in]  ENTRYPOINT ["/usr/local/bin/run_licserver.sh"]
DEBUG [in]  LABEL PROJECT=rsi_intel
DEBUG [in]  LABEL MAINTAINER="jones.clyde@gene.com"
DEBUG [in]  LABEL NAME=flexlm_license_server
DEBUG [in]  LABEL VERSION=2.10.0.016
DEBUG [in]  LABEL GENERATE_SINGULARITY_IMAGE=true
DEBUG [in]  LABEL PRODUCTION=false
(venv3) intel_lic_servers ( spython_test 0S-1U ) % spython --version
0.0.80