test for singularity 3.+ over travis CI never gonna be executed

[al3x609]

singularity-cli/.travis/before_install

Line 21 in 67cf2f1

cd /tmp && git clone -b vault/release-2.5 https://github.com/singularityware/singularity.git && cd singularity && ./autogen.sh && ./configure --prefix=/usr/local && make && sudo make install

What is your position regarding creating integration tests for version 3 of singularity?

I think the ones that are now failed, in the case of porting them to spython for singularity 3. +

[vsoch]

It’s a good idea!

[al3x609]

@vsoch this test function need to be updated

singularity-cli/spython/tests/test_utils.py

Lines 75 to 85 in 307f0d2

	def test_check_get_singularity_version(self):
	'''check that the singularity version is found to be that installed'''
	print("Testing utils.get_singularity_version")
	from spython.utils import get_singularity_version
	version = get_singularity_version()
	self.assertTrue(version != "")
	os.environ['SPYTHON_SINGULARITY_VERSION'] = "3.0"
	version = get_singularity_version()
	self.assertTrue(version == "3.0")

e.g with ...

 def test_check_get_singularity_version(self): 
     '''check that the singularity version is found to be that installed''' 
     print("Testing utils.get_singularity_version") 
     from spython.utils import get_singularity_version 
     version = get_singularity_version() 
     self.assertTrue(version != "") 
     os.environ['SPYTHON_SINGULARITY_VERSION'] = "singularity version 3.1.0" 
     version = get_singularity_version() 
     self.assertTrue(version == "singularity version 3.1.0" )

note: Im no sure if the last releases of singularity 3.1.0 return the string "singularity version 3.1.0"

for the command singularity --version; Im working with the main branch from the github repo, then my version string is: :

"singularity version 3.1.0-29.ga78434c"

[vsoch]

Need to figure out how to install GoLang before we get there @al3x609 !

[al3x609]

ok, I think the same as you, Golang is a very big dependency for this tool :(

[vsoch]

See commits here #87 if you are interested in working on this.

[al3x609]

ok, I will see that to night. we talk later
bye 👍

[vsoch]

hey @al3x609 your wish has been granted! I took a few days because I wanted to do it right - I first made a set of Singularity Orbs to make installing Singularity across versions easy 👉 https://circleci.com/orbs/registry/orb/singularity/singularity then I came back here and re-wrote the config to use them. Now we have testing for 2 and 3.

[vsoch]

I'm going to close the issue, please re-open if needed! I'm going to work on adding the OCI commands to the client next.