Skip to content

Adding linting, various fixes. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsoch merged 27 commits into from
May 28, 2019
Merged

Adding linting, various fixes. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f1c19c3
Restore SPYTHON_SINGULARITY_VERSION after test
Flamefire May 27, 2019
d96c1a6
Cleanup unused imports
Flamefire May 27, 2019
47d49d8
Fix missing imports and typos/C&P bugs
Flamefire May 27, 2019
9cfe7d1
Fix singleton comparisons (None, True)
Flamefire May 27, 2019
b906b4e
Fix wrong indents
Flamefire May 27, 2019
63a4bec
Fix super() calls
Flamefire May 27, 2019
9739e21
Fix conflict with overriden get_uri
Flamefire May 27, 2019
c09c60b
Use enumerate
Flamefire May 27, 2019
e70783a
Add missing sudo param
Flamefire May 27, 2019
8905507
Fix regexp
Flamefire May 27, 2019
fef4d28
Cleanup
Flamefire May 27, 2019
40520d5
Remove or fix unused variables
Flamefire May 27, 2019
888f61d
Add linter to CI
Flamefire May 27, 2019
faa97d7
Fix remaining lint issues
Flamefire May 27, 2019
2a43fd1
Bump version to 0.0.60
Flamefire May 27, 2019
9d18cd8
Implement split_uri superseding get_uri/remove_uri
Flamefire May 28, 2019
fae8cbb
Add tests for get_uri
Flamefire May 28, 2019
915721b
Rename member attribute uri to protocol
Flamefire May 28, 2019
a5d7b0e
Unify inspect output
Flamefire May 28, 2019
bf0a702
Merge branch 'master' into fix/misc
vsoch May 28, 2019
17d54f8
fixing linting errors
vsoch May 28, 2019
da9ac98
bumping version
vsoch May 28, 2019
54add0c
linter contradicted itself
vsoch May 28, 2019
50d94af
adding check for data to support having/not
vsoch May 28, 2019
afe24ab
fixing entrypoint to use both entrypoint and command
vsoch May 28, 2019
e433424
startscript added with same content as runscript
vsoch May 28, 2019
faefa51
adding one more check that image is defined before executing command
vsoch May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@ install_python_2: &install_python_2
echo "Miniconda 2 is already installed, continuing to build."
fi

run_linter: &run_linter
name: run linter
command: |
$HOME/conda/bin/pip install --upgrade pylint
cd ~/repo
$HOME/conda/bin/pylint spython

test_spython: &test_spython
name: Test Singularity Python (Singularity Version 2 and 3)
command: |
Expand Down Expand Up @@ -99,6 +106,7 @@ jobs:
- singularity/debian-install-3:
singularity-version: 3.1.0
- run: *install_spython
- run: *run_linter
- save_cache:
paths:
- /home/circleci/conda
Expand All @@ -121,6 +129,7 @@ jobs:
- singularity/debian-install-3:
singularity-version: 3.1.0
- run: *install_spython
- run: *run_linter
- save_cache:
paths:
- /home/circleci/conda
Expand Down
Loading