WIP: Use pytest for tests #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on instructions at https://discuss.circleci.com/t/how-to-add-a-path-to-path-in-circle-2-0/11554/9
Adjust cache keys Assert version after (potential) installation Fixes singularityhub#118
Member
|
hey do you want me to fix the linting issues? Happy to :) |
Contributor
Author
|
No it's fine. Marked the PR as WIP because I wanted to try how it works on CI, I'm not yet done. |
Member
|
Alrighty - I'm well into the refactor for the recipes, I'll take the fix for #111 |
Flamefire
force-pushed
the
pytest
branch
4 times, most recently
from
4a36b4e to
4943bb1
Compare
Contributor
Author
|
I'm off till monday. You can take this over to see if you can fix the python2 failure. Not sure why the filter doesn't work there... |
Member
|
You got it! Thanks @Flamefire, enjoy your time off. |
Contributor
Author
|
Just got an easy idea: use a pytest decorator to skip this if singularity 2. Then you only need 1 cmd to run all tests. |
Member
|
okay back in business, home safely! Starting to work on this now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pytest allows for faster writing of tests due to easier syntax as well as including e.g. coverage and other pytest plugins