Skip to content

Conversation

@vsoch
Copy link
Member

@vsoch vsoch commented Jun 27, 2019

This pull request will allow the user to specify a list of options to each of exec, shell, and run, and also if the execution should be --writable. I've also updated the documentation (and docstrings) with these examples.

This will close #138

vsoch added 2 commits June 27, 2019 08:51
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented Jun 27, 2019

@JayjeetAtGithub you can test this fix. First, remove all previous spython versions. Do this until it tells you it is installed:

pip uninstall spython

Then, clone this branch and install:

git clone -b add/options-writabl  https://github.com/singularityhub/singularity-cli
cd singularity-cli
python setup.py install

And then try the commands that were not working for you! I've updated the docs here to show them as well.

@JayjeetAtGithub
Copy link

@vsoch Thanks a lot! All well now.

@vsoch
Copy link
Member Author

vsoch commented Jun 27, 2019

Ready to merge?

@JayjeetAtGithub
Copy link

Yep 😄

@vsoch
Copy link
Member Author

vsoch commented Jun 27, 2019

You got it! Please give me a few minutes to release to pypi, I will post the link here when it's done.

@vsoch vsoch merged commit 2a4b05f into master Jun 27, 2019
@vsoch vsoch deleted the add/options-writabl branch June 27, 2019 13:12
@vsoch
Copy link
Member Author

vsoch commented Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--writable option for execute/run not working in spython

3 participants