Match WORKDIR function in Dockerfile when converting to singularity recipe #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et singularity parser to generate 'makedir -p' to match.
Member
|
This works for me! Could you please bump the version and update the CHANGELOG to indicate the change? |
Member
|
You’ll also need to update the tests that are failing (they check content of files that is now changed). |
Merged
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile WORKDIR creates a directory if it does not exist. spython recipe conversion previously only generates "cd {dir}"
This adds "mkdir -p {dir}" before the "cd" to match the WORKDIR semantics in Dockerfiles.