Skip to content

Conversation

@kinow
Copy link
Contributor

@kinow kinow commented Feb 6, 2019

Hi,

Saw the description of the project in PYPI, and also #79. I contribute to a project that also displays its README.md as long description. But in order for the formatting to be correctly rendered, we needed to set the content type in the setup.py.

This pull request simply adds that to the setup.py here too :-)

Cheers
Bruno

@vsoch
Copy link
Member

vsoch commented Feb 6, 2019

Awesome! I had wondered how to do this. I'll merge now, and the update on pypi will coincide with a future release. Thanks for the fix!

@vsoch vsoch merged commit 847750f into singularityhub:master Feb 6, 2019
@vsoch
Copy link
Member

vsoch commented Feb 7, 2019

hey @kinow ! Just a quick question - I updated sregistry-cli today and added the metadata to render the long description as markdown... is this what it's supposed to look like? -> https://pypi.org/project/sregistry/

@kinow
Copy link
Contributor Author

kinow commented Feb 7, 2019

hey @vsoch that's not how it's supposed to look like. Have you uploaded via twine? When doing changes like this, I find that using the Test instance of PYPI can be helpful too (though you need to create yet another account there...). But that way you can play with the setup.py and see if we missed anything.

@kinow
Copy link
Contributor Author

kinow commented Feb 7, 2019

Oh, it says "Last released: Feb 7, 2019", so I believe you uploaded a new version. Weird the readme not being correctly rendered.

@vsoch
Copy link
Member

vsoch commented Feb 7, 2019

Ah that must be it! Nope I'm not using twine yet, but I'll do that next time (and poke you on here with an update!) Thanks for letting me know this, I've actually been trying to figure it out for a bit (and it fails each time).

@kinow
Copy link
Contributor Author

kinow commented Feb 7, 2019

Thank you @vsoch ! Hopefully it will work next time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants