Skip to content

Conversation

@vsoch
Copy link
Member

@vsoch vsoch commented Feb 21, 2019

This PR will fix the Client.instances() command so that if the user provides a name, a single instance is returned instead of a list. This will close #83

@vsoch
Copy link
Member Author

vsoch commented Feb 21, 2019

@al3x609 if you might kindly test the PR here - we want to make sure:

  • when more than one instance is running, when you do Client.instances("myinstance") (providing a particular name) it returns an instance object (and not a list).
  • the issues with version 2.* checking are fixed here too :)

@vsoch
Copy link
Member Author

vsoch commented Feb 21, 2019

ok fixed.

@vsoch
Copy link
Member Author

vsoch commented Feb 21, 2019

@al3x609 ready for merge?

@vsoch vsoch merged commit 67cf2f1 into master Feb 21, 2019
@vsoch vsoch deleted the fix/list-instances branch February 21, 2019 22:42
@vsoch
Copy link
Member Author

vsoch commented Feb 21, 2019

@al3x609
Copy link
Contributor

al3x609 commented Feb 21, 2019

👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting an instance object using client.instances('instance_name') returns list of all instances

3 participants