Skip to content

Conversation

@vsoch
Copy link
Member

@vsoch vsoch commented Feb 6, 2020

This will add black lint formatting (and a test for it) along with bumping the date in docstrings, regenerating the python docs, adding the version to the changelog, and integrating the changes in PR 27.

pierlauro and others added 6 commits February 6, 2020 16:37
Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented Feb 6, 2020

For future folks, the version of black does matter (and I didn't have the same version locally). The one used now in the CI installed by conda is:

$ pip install black==19.3b0

Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch
Copy link
Member Author

vsoch commented Feb 6, 2020

phew, finally! The tests were using an app with django and nginx that requires compiling nginx, and instead I switched to a much simpler deployment of a webserver.

@vsoch vsoch merged commit f86306d into master Feb 6, 2020
@vsoch vsoch deleted the add/black-pr-27 branch February 6, 2020 17:33
@vsoch vsoch mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants