Adding test for depends_on #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need feedback about the format of the recipe, because as is currently, there seems to be a circular dependency. Either this is intended (and we want to trigger the error and then expect it in the test) or I did not implement the recipe as it should be. Signed-off-by: vsoch <vsochat@stanford.edu>
Merged
Member
Author
|
This is integrated with #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes #31, and also starts to add a test for it. @pierlauro - please test this out locally because I haven't finished it yet and I have questions:
I've created a setup for the test we need for depends_on, this is kept in tests/configs/depends_on, and copied to a temporary directory to run. Take a look at the singularity-compose.yml and let me know if this is what you had in mind - should this recipe trigger an exception for the dependency or not (it currently does). Once we've discussed this, I can either:
And then print out the startscript echos somewhere so that we can verify the order of starting up. Let me know when you've had a chance to take a look, and with your feedback I can work on one of the next steps listed above!