Command args #33
Merged
Command args #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I decided to use |
vsoch
approved these changes
Mar 18, 2020
Member
vsoch
left a comment
vsoch
left a comment
There was a problem hiding this comment.
Wow, so beautifully done @pierlauro - after the other PRs you've done you're a pro! There is literally just one tiny typo in the docs, but since I think you are in a different time zone and this looks good, I'm happy to merge this and then fix for you before doing the release.
Signed-off-by: vsoch <vsochat@stanford.edu>
Member
|
okay, I just did one more push because we needed to add a line to circleci/config.yml to make sure that the test runs in circle, and also to fix the tiny typo in the docs. As soon as this passes we should be good to go. |
Member
|
Woot! Here is the new test:
|
Member
Contributor
Author
|
Perfect, thank you for the fast review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to specify in the singularity-compose the arguments to pass to an instance's startscript