Add network->enable feature to compose file

[PauloMigAlmeida]

By default singularity-compose will always append --net to command to be executed in which it will prompt for either having --network=none or --fakeroot added.

Depending on your environment's configuration and isolation requirements you may want to be able to instruct singularity-compose not to append --net or any network-related params to the command sent to singularity CLI.

The example below will disable the network features:

  instance1:
    ...
    network:      
      enable: true | false

[vsoch]

For these two, how about:

for key in ["enable", "allocate_ip"]:
    self.network[key] = self.network.get(key, True)

[PauloMigAlmeida]

I like the suggestion! Will do it it now

[vsoch]

Oh I absolutely love this!! I made a suggestion for a more concise population of True values, and other than that let's just add a note to the CHANGELOG and another tiny version bump.

[PauloMigAlmeida]

Really liked the suggestion, thanks for that @vsoch

I just implemented the suggestions that you gave, let me know if there is anything else that I can do on this PR

[vsoch]

I haven't tried this so I don't know the answer - do we want a hostname if we don't enable network options?

[PauloMigAlmeida]

Good point. I tried that. It doesn't enable the network options.. I agree that sounds counter intuitive but singularity is funny sometimes, ay? 😂

[PauloMigAlmeida]

But if you want I can move the --hostname under the same if statement.

[vsoch]

I think it's okay to leave - if there is some addition to a resolver file that gives the container a hostname without setting up networking, I suppose someone could want that? And it doesn't hurt to have it. So let's leave as is until there is more evidence to change that.