.version file should be written at the top level of module folders#451
Merged
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Member
Author
|
okay let's ignore Circle for now - the CI is wonky (it's not able to get the base image updates). |
|
Just ran the same tests I did for the bug report. Looks to be working well with the changes in the branch.
|
with default as true, as it makes the modules a little better organized. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
This was referenced Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change will add a .version file to the top level of module folders on install to address #450. I don't have a cluster to test this on easily, so @nlvw it would be greatly appreciated if you'd like to test! @eburgueno I also fixed the bug that you found in the docs to close #445,
Signed-off-by: vsoch vsoch@users.noreply.github.com