Support options argument for EventTarget interface methods, fixes #34 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroderick
requested changes
Feb 26, 2018
Member
mroderick
left a comment
mroderick
left a comment
There was a problem hiding this comment.
Thank you for the detailed pull request 🍦
I only have one minor comment
lib/event/event-target.js
Outdated
| }; | ||
| } | ||
| return { | ||
| capture: !!options.capture, |
Member
There was a problem hiding this comment.
Using !! for implicit type coercion has a few drawbacks
- it's easy for Future Contributor to make mistakes that do not look wrong at a glance (
!,!!,!!!), which means it won't get caught be linters or reviewers - it's difficult to understand for newcomers to JavaScript
Would you mind changing the !! to use the Boolean() function instead?
capture: Boolean(options.capture),
Contributor
Author
|
Thank you for review @mroderick, no concerns about using Boolean function, updated PR |
mroderick
approved these changes
Mar 1, 2018
Member
|
Thank you 👍 This has been published as |
Contributor
|
@betalb We miss documentation for this feature. Any chance you could supply some docs? |
Contributor
Author
|
@fatso83 Sorry, forgot to update, I saw separate ticket, will try to do this asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for options argument
This PR also fixes handler registration with or without capture flag. Even though useCapture flag is not relevant for XHR object, browsers follow spec in this respect and allow to register 2 handlers if they have different capture flags: see last step in https://dom.spec.whatwg.org/#dom-eventtarget-addeventlistener