Conversation
|
The documentation fails in the current stage as we do not provide a library of internal types/functions. I would add these eventually. |
- Rework on the TwoLevelTree type - Works with out RepresentativePeriods or OperationalScenarios
OperationalScenarios
Used JuliaFormatter
ea702c6 to
50cc128
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
|
I added now a first take on the documentation for compilation properties. There is some weird behavior in I personally would say that it is more or less now a version which can be seen as acceptable. I personally would however do changes to it in PR #23 as the readjustments may simplify the overall understandability. Note that this will be a separate commit in said branch in the end. Similarly, all open points could be an open discussion for us pre releasing the new version. |
This PR focuses on a rework of the
TwoLevelTreestructure. While it is not yet finalized, it includes the following main points:StrategicStochasticProfilesto be consistent with the other type of profiles.WithPrevon the strategic periods of aTwoLevelTreeis now basing it on the parent node. That is no changes are requiredThere are still a few things to be finalized:
TwoLevelTree.Minor comments from my end:
TwoLevelTreeat the moment, as it includes all nodes from the beginning. This does however work quite well. It could be reworked eventually.As a last point: All tests are running. I included new tests for the combination with
RepresentativePeriods. However, I cannot guarantee that all functions for other subtypes are working, e.g., functions forStrategicPeriod. I though of formatting in the end, not before. The key reason for that is that I want to avoid any issues ;)