Fixes #126 - hash160/ripemd160 were generating incorrect ASM#132
Open
landabaso wants to merge 3 commits intosipa:masterfrom
Open
Fixes #126 - hash160/ripemd160 were generating incorrect ASM#132landabaso wants to merge 3 commits intosipa:masterfrom
landabaso wants to merge 3 commits intosipa:masterfrom
Conversation
added 3 commits
January 23, 2023 22:45
This reverts commit e9cb8c0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
When passing hex values to
ripemd160andhash160as in:hash160(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)it will generate correct ASM:OP_SIZE <20> OP_EQUALVERIFY OP_RIPEMD160 <aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> OP_EQUALNot omitting the
<aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>When using the special value
H, ASM will then produce<H>instead of lower case<h>.