Support "record call" for publish #2052
Closed
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfuchs
reviewed
Jan 7, 2026
daemon/call_interfaces.c
Outdated
| ctx->ngbuf->sdp_out = sdp_out.s; | ||
| parser->dict_add_str(ctx->resp, "sdp", &sdp_out); | ||
| sdp_out = STR_NULL; // ownership passed to output | ||
| if (sdp_out.len) { |
Member
There was a problem hiding this comment.
Wondering about this additional condition here. If sdp_create returned success then the string should always be valid. Is this needed?
Contributor
Author
There was a problem hiding this comment.
I copied it from call_offer_answer_ng (and same logic exists in call_subscribe_request_ng). If the condition is redundant then I guess it should be removed everywhere.
orgads
force-pushed
the
publish-record-call
branch
from
d395293 to
5529ccc
Compare
Initial call recording is set by "record call". This worked for offer/answer but not for publish.
orgads
force-pushed
the
publish-record-call
branch
from
5529ccc to
d1698e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial call recording is set by "record call". This worked for offer/answer but not for publish.