Downgrade circleci image to PHP 5.6#86
Merged
sirbrillig merged 13 commits intomasterfrom May 10, 2019
Merged
Conversation
Contributor
|
Why was the upgrade to PHP 5.6 needed? WPCS and PHPCS require PHP >=5.4. I've also just made VIPCS support >=5.4 as well, and was hoping not to have to revert that when pulling in VA. |
Owner
Author
|
Oh, good question. I doubt it was intentional but let me see. Looking at the things added by php 5.5 and php 5.6, the only thing that stands out to me is:
I will create a branch that adds PHP 5.4 to the CI and see what happens. |
Owner
Author
|
See #191 where I'll probably spend 5 hours trying to figure out how to get a php 5.4 environment (there's no pre-built docker image on circleci). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a null coalesce operator that was accidentally added in #83, creating a bug with older versions of PHP.
This also updates the circleci configuration to prevent such regressions from happening in the future.
Fixes #85